Few cents about my commits

fix #567: GlobalValueEnumeration crash

|

fix #561: wrong pointer to flexible array member

|

Background

issue #561 ExtAudioFile.read() isn’t playing nice anymore. @yajirobe69 in comment described that possible root case it is a due field annotation was changed from @Array({1}) to @ByVal.
buffers field is a flexible array member of AudioBuffer struts. To work with this array required to get pointer to first struct (member itself) and then navigate in it by using methods of Struct class.

Root case

Root case of issue was introduced in e0b6db6. Accessing struct member is a struct kind and is annotated as @ByVal will cause following:

  • first element being accessed;
  • copied;
  • copy of it is returned

While it is normal to read struct by value, in flexible array member case it is wrong as:

  • pointer to first struct is required, not pointer to the COPY;
  • future operations with copy, e.g. setting elements (at index 1+) might cause memory corruption.

The fix

fix #557: Applying fixes to libcore

|

ClassCastException: ObjC protocol and its Java implementation

|

Background:

There is many API in CocoaTouch where argument is ObjC protocol type. In RoboVM protocols are mapped into interfaces. The problems begin when bro-bridge tries to marshall this protocol implementation into the native object:

UIToolbar toolbar = new UIToolbar();
toolbar.setDelegate(bar -> UIBarPosition.Any);

causes:

java.lang.ClassCastException: com.mycompany.myapp.Main$$Lambda$1 cannot be cast to org.robovm.objc.ObjCObject
	at org.robovm.objc.ObjCObject$Marshaler.protocolToNative(ObjCObject.java:388)
	at org.robovm.apple.uikit.UIToolbar.$m$setDelegate$(Native Method)
	at org.robovm.apple.uikit.UIToolbar.setDelegate(UIToolbar.java)
	at com.mycompany.myapp.Main.didFinishLaunching(Main.java:26)

Root case: protocol marshaller can handle only ObjCObject. Indeed, there is no way to marshal random Java class to ObjC native world.

The existing workaround:

AltPods: pods updated - 1.15.0-SNAPSHOT

|

AltPods were updated to v1.15.0-SNAPSHOT to sync with recent releases.

Updated pods

These pods were pushed to https://oss.sonatype.org/content/repositories/snapshots maven repo under 1.15.0-SNAPSHOTS version. Source code @github

Updates are not fully tested, please open issue if bug found.

NB: AltPods – are robopods kept at my personal standalone repo. This is done to prevent main robopods repo from turning into code graveyard. As these pods have low interest of community and low chances to be updated.

re-thinking a way SWIFT dependencies are resolved

|

Background:

First time issue was reported on gitter

libswiftCoreMIDI.dylib is not found in swift paths

Later it was communicated that workaround doesn’t work during submition to Apple: ERROR ITMS-90209: “Invalid Segment Alignment. The app binary at ‘SwiftSupport/iphoneos/libswiftCoreMIDI.dylib’ does not have proper segment alignment. Try rebuilding the app with the latest Xcode version.”

Issues:

  • RoboVM can detect swift dependencies only in dynamic frameworks. For static libraries/frameworks workaround was introduced.
  • Today dynamic framworks might link again runtime swift libraries – these should not be copied to .app/Frameworks folder. These dependecies can be observed using otool -L command:
/usr/lib/swift/libswiftWebKit.dylib (compatibility version 1.0.0, current version 610.1.28, weak)
@rpath/libswiftAVFoundation.dylib (compatibility version 1.0.0, current version 1991.1.1, weak)  

there libswiftWebKit.dylib is from runtime location(and RoboVM can’t copy it) and libswiftAVFoundation.dylib to be bundled into application (have to be bundled).

Solutions:

AltPods: pods updated - 1.14.0-SNAPSHOT

|

AltPods were updated to v1.14.0-SNAPSHOT to sync with recent releases.

New pods

Updated pods

These pods were pushed to https://oss.sonatype.org/content/repositories/snapshots maven repo under 1.14.0-SNAPSHOTS version. Source code @github

Updates are not fully tested, please open issue if bug found.

NB: AltPods – are robopods kept at my personal standalone repo. This is done to prevent main robopods repo from turning into code graveyard. As these pods have low interest of community and low chances to be updated.

Compiler: fix for @ByValue fields got returned as @ByRef

|

@vaaneeunbnd reported an issue at gitter:

I am using GLKMatrix4 as a modelviewmatrix in my robovm app but whenever I try to apply translation to it: modelViewMatrix.createTranslation(0.0f, 0.0f, -1.0f); It crashes without a debug log, can someone please help me with this

But diagnostic report contains a crash log:

Exception Type:        EXC_BAD_ACCESS (SIGBUS)
Exception Codes:       KERN_PROTECTION_FAILURE at 0x0000000106a416e0
Exception Note:        EXC_CORPSE_NOTIFY
VM Regions Near 0x106a416e0:
--> __TEXT                      106a18000-106a48000 
0   Java_libcore_io_Memory_pokeInt + 11
1   [J]libcore.io.Memory.pokeInt(JIZ)V + 119
2   [j]libcore.io.Memory.pokeInt(JIZ)V[clinit] + 71
3   [j]libcore.io.Memory.pokeInt(JIZ)V[Invokestatic(java/nio/MemoryBlock)] + 14
4   [J]java.nio.MemoryBlock.pokeInt(IILjava/nio/ByteOrder;)V + 184 (MemoryBlock.java:220)
5   [j]java.nio.MemoryBlock.pokeInt(IILjava/nio/ByteOrder;)V[Invokevirtual(java/nio/Dire
6   [J]java.nio.DirectByteBuffer.putFloat(IF)Ljava/nio/ByteBuffer; + 393 (DirectByteBuffer.java
7   [j]java.nio.ByteBuffer.putFloat(IF)Ljava/nio/ByteBuffer;[Invokevirtual(java/nio/Byte
8   [J]java.nio.ByteBufferAsFloatBuffer.put(IF)Ljava/nio/FloatBuffer; + 208 (Byt
9   [j]java.nio.FloatBuffer.put(IF)Ljava/nio/FloatBuffer;[Invokevirtual(org/robovm/apple/glki
10  [J]org.robovm.apple.glkit.GLKMatrix4.createTranslation(FFF)Lorg/robovm/apple/glkit/GLKM
11  [j]org.robovm.apple.glkit.GLKMatrix4.createTranslation(FFF)Lorg/robovm/apple/glkit/GLKM
12  [j]org.robovm.apple.glkit.GLKMatrix4.createTranslation(FFF)Lorg/robovm/apple/glkit/GLKMatrix4;[Invokestatic(com/mycompany/myapp/MyViewController)] + 9

And code that triggered it looks like the bellow:

CocoaTouch: regenerated to fix static methods issue

|

It is a follow up of previous post: bro-gen: static methods and polymorphism. CocoaTouch was regenerated with updated bro-gen and it caused 1000+ changes in source code. There are massive supportsSecureCoding(), getLayerClass() and also it exposed not available before constructors and APIs.

The changes proposed as PR543 and targeted to 2.3.13 version of RoboVM.

bro-gen: static methods and polymorphism

|

There is one binding trick related to inherited class methods/properties in objc code. Polymorphism is not available for static methods in Java and compiler resolves target for static call during compilation time. Following obj-c code and Java binding demostrate the issue:

@interface Abstract : NSObject
+(void) test;
@end

@interface TestObject : Abstract
@end

Corresponding binding:

public class Abstract extends NSObject {
    public Abstract() {}
    @Method(selector = "test")
    public static native void test();
}

public class TestObject extends Abstract {
    public TestObject() {}
}

Java call TestObject.test() will fail while obj-c call [TestObject test] is not. Root case – static method invocation is resolved compilation time and test() method is present in Abstract. This produces Abstract.test() call that corresponds to obj-c call [Abstract test].

The fix

Is to copy all static methods/properties from super-classes/protocols into target class. Bro-gen script was updated to do this automatically.